Repository navigation
harden(oauth): SSRF-validate token_url in llm_shared refresh/device + admin-gate /status (#11061) #11298
Description
Discrete deliverable of #11061 (umbrella #11058). Covers the two contained findings; the headline state/PKCE binding is #11297 and the remaining MEDs (device-poll rate-limit, DNS-rebinding pin, per-tenant vault, token audience) stay on #11061.
- HIGH — refresh/device SSRF bypass:
llm_shared/provider_auth.OAuthAuth._refreshnow callsrequire_allowlisted_https(self._token_url, get_oauth_allowed_hosts())before the outbound POST (coversDeviceCodeAuthtoo — it refreshes via_refresh). The OAuth host allowlist moved toautobot_shared.url_safetyas the single source. - MED — /status not admin-gated: added
check_admin_permission.
Fixed by the linked PR.
Activity
fix(security): SSRF-validate OAuth token_url in llm_shared + admin-ga…
mrveiss commentedon Jul 8, 2026
Closed — merged to Dev_new_gui via #11299.
llm_shared._refreshSSRF-validatestoken_urlbefore every outbound POST (OAuth + device refresh); OAuth allowlist consolidated inautobot_shared.url_safety;/statusadmin-gated. Verified: evil host rejected, good host allowed, blocked URL never reaches the network.