You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(lint): make canonical-check self-enforcing — add rules + fix the Make target #10577
Make canonical-check self-enforcing — add rules + fix the Make target
Part of umbrella #10569 · priority: high · the "self-enforcing" task
Problem
The runner tools/lint/canonical_check.py enforces only one rule
(py-print-smoke). The other canonical disciplines in this umbrella are not
detectable, so drift returns silently. Also, make canonical-audit calls python (absent here — only python3), so the Make target fails outright.
What to do
Fix the Make target(s) to invoke python3 (or a resolved interpreter), so make canonical-audit runs.
Add new rules to canonical_check.py (and canonical_check_infra.py where
relevant), each with fixtures under repo_tests/lint/canonical/fixtures/:
Resolved in PR #10618. make canonical-audit now invokes python3 (Makefile + .pre-commit-config). Five new rules added (auto-discovered via the existing registry): py-banned-suffix-filename (BLOCK — 0 violations repo-wide after #10575, safe), py-adhoc-db-engine / py-hardcoded-url / py-sync-requests-in-async / py-duplicate-concept (warn — residual repo-wide counts documented, per spec, to avoid redding CI on debt outside the listed files). 15 fixtures + 28 passing tests; wired into pre-commit --files and the weekly --all audit; CANONICAL_RULES.md updated; runner dogfoods its own rules. Verified: canonical_check.py --all exits 0 (0 BLOCK violations). Closing.
Activity
feat(lint): make canonical-check self-enforcing — add rules + fix Mak…
github-actions commentedon Jun 28, 2026
PR #10618 (merged to
Dev_new_gui) references this issue with a close keyword.If this issue is fully resolved, close it manually. If work remains, no action is needed.
mrveiss commentedon Jun 28, 2026
Resolved in PR #10618.
make canonical-auditnow invokespython3(Makefile + .pre-commit-config). Five new rules added (auto-discovered via the existing registry):py-banned-suffix-filename(BLOCK — 0 violations repo-wide after #10575, safe),py-adhoc-db-engine/py-hardcoded-url/py-sync-requests-in-async/py-duplicate-concept(warn — residual repo-wide counts documented, per spec, to avoid redding CI on debt outside the listed files). 15 fixtures + 28 passing tests; wired into pre-commit--filesand the weekly--allaudit; CANONICAL_RULES.md updated; runner dogfoods its own rules. Verified:canonical_check.py --allexits 0 (0 BLOCK violations). Closing.fix(lint): py-hardcoded-url prod-scope + correct BLOCK severity in ru…