Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate: Drop devices and mounts #15

Closed
wants to merge 2 commits into from
Closed

generate: Drop devices and mounts #15

wants to merge 2 commits into from

Commits on Dec 5, 2015

  1. generate: Drop runtime-supplied devices and mounts 

    Since opencontainers/runtime-spec#164 (part of the v0.1.1 release [1]), Linux
runtimes are required to supply these devices and mounts.  Specifying
them explicitly in the config should have no effect, and just makes
the config longer than it needs to be.

[1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Dec 5, 2015
    Configuration menu
    Copy the full SHA
    6d8fd60 View commit details
    Browse the repository at this point in the history

  2. generate: Drop /dev/mqueue 

    Linux runtimes are not required to supply this [1,2].  We could supply
it via ocitool, but I don't think its wise to try and define two
standards (one in opencontainers/specs for what a runtime must supply,
and another here with additional stuff), because I don't see a clear
definition of something generally useful enough to go here but not in
the spec.  For example, hosts without CONFIG_POSIX_MQUEUE could be
spec-compliant but unable to perform the mqueue mount I'm removing
here.

[1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems
[2]: opencontainers/runtime-spec#164

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Dec 5, 2015
    Configuration menu
    Copy the full SHA
    05c3827 View commit details
    Browse the repository at this point in the history