Skip to content

Commit

Permalink
feat(android): add support for upcoming react native 0.73 (#550)
Browse files Browse the repository at this point in the history
  • Loading branch information
ddikodroid authored Jun 19, 2023
1 parent 9b88efc commit bf0bbc3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ repositories {
}

android {
namespace = "com.reactnativemmkv"
compileSdkVersion safeExtGet("compileSdkVersion", 28)

// Used to override the NDK path/version on internal CI or by allowing
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.reactnativemmkv">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

This comment has been minimized.

Copy link
@yadigar-flipdish

yadigar-flipdish Jun 23, 2023

Removing package name from AndroidManifest causing issues with other builds when you upgrade. There is options to use dynamic package name in Manifest. Can't you just use them?


</manifest>

0 comments on commit bf0bbc3

Please sign in to comment.