Skip to content

Conversation

@mrogaski
Copy link
Owner

@mrogaski mrogaski commented Jan 2, 2023

Removed test and lint workflows.

Add ci.yml (#7)

Create python-publish.yml (#8)

Updated code coverage uploads.

Fixed coverage collection.

Disabled pre-commit for Python 3.7.

Updated change log.

Refactored coverage reporting and added RTD preview.

Added upload of coverage data.

Added doc tests.

Moved docs tag to extras.

Fixed Sphinx build arguments.

Updated Sphinx build.

Removing explicit version.

Updated static paths.

Documentation changes.

Added docs to dev extras.

More Sphinx testing.

Updated sys.path.

More path fixes.

More Sphinx.

Switched to sphinx-apidoc.

Fixed sphinx-apidoc arguments.

Updated pyproject.toml.

Added doctest support.

Removed test and lint workflows.
@mrogaski mrogaski force-pushed the feature/hatch-project branch from e6fd0aa to 8bc2eb3 Compare January 2, 2023 20:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #9 (6189d79) into main (06456d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           13        16    +3     
  Branches         1         2    +1     
=========================================
+ Hits            13        16    +3     
Impacted Files Coverage Δ
src/pygopher/interfaces.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"""

def __subclasscheck__(cls, subclass):
def __subclasscheck__(cls, subclass: type) -> bool:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24% of developers fix this issue

Inconsistent override: src.pygopher.interfaces.Interface.__subclasscheck__ overrides method defined in type inconsistently. Could not find parameter self in overriding signature.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

return interface_methods.issubset(class_methods)

def __instancecheck__(cls, instance):
def __instancecheck__(cls, instance: type) -> bool:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24% of developers fix this issue

Inconsistent override: src.pygopher.interfaces.Interface.__instancecheck__ overrides method defined in type inconsistently. Could not find parameter self in overriding signature.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@mrogaski mrogaski merged commit 374a617 into main Jan 2, 2023
@mrogaski mrogaski deleted the feature/hatch-project branch January 2, 2023 21:38
@mrogaski mrogaski mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants