-
Notifications
You must be signed in to change notification settings - Fork 1
Replaced poetry build system with hatch. #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed test and lint workflows.
e6fd0aa to
8bc2eb3
Compare
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 13 16 +3
Branches 1 2 +1
=========================================
+ Hits 13 16 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/pygopher/interfaces.py
Outdated
| """ | ||
|
|
||
| def __subclasscheck__(cls, subclass): | ||
| def __subclasscheck__(cls, subclass: type) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent override: src.pygopher.interfaces.Interface.__subclasscheck__ overrides method defined in type inconsistently. Could not find parameter self in overriding signature.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
src/pygopher/interfaces.py
Outdated
| return interface_methods.issubset(class_methods) | ||
|
|
||
| def __instancecheck__(cls, instance): | ||
| def __instancecheck__(cls, instance: type) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent override: src.pygopher.interfaces.Interface.__instancecheck__ overrides method defined in type inconsistently. Could not find parameter self in overriding signature.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Removed test and lint workflows.
Add ci.yml (#7)
Create python-publish.yml (#8)
Updated code coverage uploads.
Fixed coverage collection.
Disabled pre-commit for Python 3.7.
Updated change log.
Refactored coverage reporting and added RTD preview.
Added upload of coverage data.
Added doc tests.
Moved docs tag to extras.
Fixed Sphinx build arguments.
Updated Sphinx build.
Removing explicit version.
Updated static paths.
Documentation changes.
Added docs to dev extras.
More Sphinx testing.
Updated sys.path.
More path fixes.
More Sphinx.
Switched to sphinx-apidoc.
Fixed sphinx-apidoc arguments.
Updated pyproject.toml.
Added doctest support.