Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some possible leaks in the new ping/pong code refs #868 #869

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

hiredman
Copy link
Contributor

move ping scheduling to be conditional on a client still existing

cancel existing scheduled ping and ping timeouts before scheduling another

move ping scheduling to be conditional on a client still existing

cancel existing scheduled ping and ping timeouts before scheduling another
@hiredman
Copy link
Contributor Author

maybe fixes #868, but I've never figured out how to run the tests (#753)

@mrniko mrniko merged commit 413ffc0 into mrniko:master Oct 12, 2022
@mrniko
Copy link
Owner

mrniko commented Oct 12, 2022

Thanks for contribution

osaka911 pushed a commit to osaka911/netty-socketio that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants