Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose client auth option #830

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Expose client auth option #830

merged 1 commit into from
Jul 3, 2022

Conversation

huws
Copy link
Contributor

@huws huws commented Oct 19, 2021

This fixes issue #503, by exposing a client auth option for TLS connections. When configured, client connection attempts are rejected unless they present a certificate allowed by the trust store. If no trust store is configured, the setting has no effect.

@huws
Copy link
Contributor Author

huws commented Feb 2, 2022

@mrniko - Is there any other information that you'd need in order to merge this fix?

Please let me know if there's anything I've missed. Thanks!

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work and add some test for it would be great.

@huws
Copy link
Contributor Author

huws commented Jun 28, 2022

@liangyuanpeng Please can you clarify your request? As far as I can tell, there are no existing tests for any of the Configuration class. Further, the tests seem to be globally disabled in pom.xml, and fail if manually enabled.

@mrniko mrniko merged commit 5230ffc into mrniko:master Jul 3, 2022
@mrniko
Copy link
Owner

mrniko commented Jul 3, 2022

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants