suppress ENOTDIR errors similar to ENOENT - #496
Open
wernst wants to merge 2 commits into
Open
Conversation
Author
|
Alternatively #485 would also address this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR includes ENOTDIR as a suppressed file system error in the same way that ENOENT is. I would make the case that they are spiritually similar when dealing with glob resolution ("a path to this file could not be found") and thus should be treated the same way. If you disagree that is fine, I will not be offended.
What changes did you make? (Give an overview)
Added checks for ENOTDIR when determining if an error is fatal