Ignore patterns don't work in `ignore` option

[alexander-akait]

Environment

• OS Version: ubuntu 17.10
• Node.js Version: latest

Actual behavior

Ignore patterns don't work in ignore option.

Expected behavior

Ignore patterns should be work in ignore option. node-glob works perfect.

Steps to reproduce

1. Create file.txt with any contents.
2. Create file.yaml with any contents.

Code sample

const fg = require('fast-glob');

fg(['**/*'], {
  absolute: true,
  dot: true,
  ignore: [`!{**/*,*}.txt`],
  onlyFiles: true
})
  .then((entries) => console.log(entries));

[mrmlnc]

Hello, @evilebottnawi,

You really want to use negative patterns in the ignore property? Right now you can use positive patterns instead of negative and it's works fine.

[alexander-akait]

@mrmlnc yes, i have tool which check file contents with extension and report if something wrong, i want get all files exclude some extensions which i don't support. Also '**/*' pattern can be configured by users (i.e. images/**/*).

[mrmlnc]

Sounds like a feature request.

JFYI: Right now you can use the following work around:

const fg = require('fast-glob');

await fg(['**/*'], {
  absolute: true,
  dot: true,
  ignore: ['{**/*,*}.txt'], // without !
  onlyFiles: true
})

[mrmlnc]

Just one question:

Why you use the {**/*,*} pattern instead of just a **/*?

As I know, **/* involve * and can be interpreted as «entries with txt extension on any nesting level».

[alexander-akait]

@mrmlnc yes, any nesting levels. For me it was breaking change, because node-glob support this behavior by default. Workaround glob all files except *.txt, i need vice versa logic.

[reklatsmasters]

I think this feature related to xojs/xo#65 issue.

[mrmlnc]

@reklatsmasters, I think these things are different. Based on the description of this issue – we just want to allow the use ! in the ignore option.

[alexander-akait]

@reklatsmasters @mrmlnc yep, difference