Difference behavior for dot files on windows and linux

[alexander-akait]

Environment

• OS Version: windows/linux
• Node.js Version: 8.15.0

Actual behavior

We have file directory/.dottedfile

pattern - {file.txt,noextension,directory/**/*}

On linux - file founded
On windows - no

https://ci.appveyor.com/project/webpack-contrib/copy-webpack-plugin/builds/22457587/job/y5320ckr1fvs6r67

Expected behavior

Founded on linux and windows, or provide documentation why it is doesn't work and/or how can be fixed

Steps to reproduce

Below

Code sample

fg(['{file.txt,noextension,directory/**/*}'], { dot: true }).then((entries) => console.log(entries));

[mrmlnc]

It looks weird. Does not work on Windows 10 and WSL (Ubuntu). Also does not work with the minimatch, picomatch and globrex package.

This a RegExp for Entry filter:

/^(?:(?:\.[\\\/](?=.))?(?:bench\.js|directory[\\\/](?:(?!(?:[\\\/]|^)(?:\.{1,2})($|[\\\/]))(?!\.{2}).)*?[\\\/](?!(?:^|[\\\/])\.{1,2}(?:$|[\\\/]))(?!(\.{2}|\.[\\\/]))(?=.)[^\\\/]*?)(?:[\\\/]|$))$/

The entries in my directory:

bench.js
directory/.dotted

And…

const re = /^(?:(?:\.[\\\/](?=.))?(?:bench\.js|directory[\\\/](?:(?!(?:[\\\/]|^)(?:\.{1,2})($|[\\\/]))(?!\.{2}).)*?[\\\/](?!(?:^|[\\\/])\.{1,2}(?:$|[\\\/]))(?!(\.{2}|\.[\\\/]))(?=.)[^\\\/]*?)(?:[\\\/]|$))$/;

re.test('bench.js'); // → true
re.test('directory/.dotted'); // → false

[mrmlnc]

As a temporary solution, you can divide the pattern into several:

const entries = fg.sync(['bench.js', 'directory/**/*'], {
    dot: true
});

[alexander-akait]

@mrmlnc thanks, we want to migrate copy-webpack-plugin (https://www.npmjs.com/package/copy-webpack-plugin) on last globby (uses fat-glob) and can't use this workaround, unfortunately we cannot migrate due to this problem, also i find something strange this ( and ) characters you can see all failed tests https://ci.appveyor.com/project/webpack-contrib/copy-webpack-plugin/builds/22457587/job/y5320ckr1fvs6r67 (on old globby with node-glob all tests passed)

[jonschlinkert]

also i find something strange this ( and ) characters you can see all failed tests https://ci.appveyor.com/project/webpack-contrib/copy-webpack-plugin/builds/22457587/job/y5320ckr1fvs6r67 (on old globby with node-glob all tests passed)

FWIW, the tests passed with node-glob because node-glob can't handle non-extglob parenthesis and so it just escapes everything, resulting in \\(. It's not technically "working", it's just coincidental that your pattern happened to work, as the escaping often results in nothing matching at all.

To use parens with micromatch, you can either use a valid extglob, like +(foo|bar), or escape the parens with backslashes, like \\(.

Happy to help if you still have questions.

[alexander-akait]

@jonschlinkert can you clarify with examples, thanks