Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markDirectories doesn't work with absolute:true given a relative path #121

Closed
rijnhard opened this issue Oct 11, 2018 · 1 comment
Closed
Assignees

Comments

@rijnhard
Copy link
Contributor

Actual behavior

markDirectories does not work when the glob is a relative path and absolute is set to true. Digging into the code it looks like the order of operations of Reader.prototype.transform is incorrect causing it to undo the marked directories/

/full/path/test/things/a
/full/path/test/things/b
/full/path/test/things/c

Expected behavior

/full/path/test/things/a/
/full/path/test/things/b/
/full/path/test/things/c/

Code sample

import fglob from 'fast-glob'; 

const relativeGlob = 'test/fixtures/*/';

async function test() {
	const list = await fglob(relativeGlob, { absolute : true, onlyDirectories: true, markDirectories:true });

	console.info(list);
}

test();
@rijnhard rijnhard mentioned this issue Oct 11, 2018
@mrmlnc mrmlnc self-assigned this Oct 11, 2018
mrmlnc added a commit that referenced this issue Oct 15, 2018
@mrmlnc mrmlnc mentioned this issue Nov 9, 2018
10 tasks
@mrmlnc
Copy link
Owner

mrmlnc commented Nov 9, 2018

Will be shipped at #136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants