Fix off-by-one error in PyMem_Malloc() call in

psyco_conn_set_client_encoding(). Fixes psycopg#211
mrmilosz · Feb 13, 2008 · b5f4a5f · b5f4a5f
1 parent 6c2e3ab
commit b5f4a5f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/psycopg/connection_type.c b/psycopg/connection_type.c
@@ -195,12 +195,12 @@ psyco_conn_set_client_encoding(connectionObject *self, PyObject *args)
     if (!PyArg_ParseTuple(args, "s", &enc)) return NULL;
 
     /* convert to upper case and remove '-' and '_' from string */
-    buffer = PyMem_Malloc(strlen(enc));
+    buffer = PyMem_Malloc(strlen(enc)+1);
     for (i=j=0 ; i < strlen(enc) ; i++) {
         if (enc[i] == '_' || enc[i] == '-')
-        continue;
-    else
-        buffer[j++] = toupper(enc[i]);
+            continue;
+        else
+            buffer[j++] = toupper(enc[i]);
     }
     buffer[j] = '\0';