Skip to content

Commit

Permalink
* psycopg/utils.c (psycopg_escape_string): same here.
Browse files Browse the repository at this point in the history
	* psycopg/adapter_binary.c (binary_escape): simplify PostgreSQL
	version check.

	* setup.py (psycopg_build_ext.finalize_options): use a single
	define of the PostgreSQL version in a form that can easily be used
	by #ifdefs.
  • Loading branch information
jhenstridge committed Feb 17, 2009
1 parent 2a94dfa commit 9067bde
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 11 deletions.
9 changes: 9 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
2009-02-17 James Henstridge <james@jamesh.id.au>

* psycopg/utils.c (psycopg_escape_string): same here.

* psycopg/adapter_binary.c (binary_escape): simplify PostgreSQL
version check.

* setup.py (psycopg_build_ext.finalize_options): use a single
define of the PostgreSQL version in a form that can easily be used
by #ifdefs.

* tests/test_dates.py (DatetimeTests, mxDateTimeTests): full test
coverage for datetime and time strings with and without time zone
information.
Expand Down
4 changes: 1 addition & 3 deletions psycopg/adapter_binary.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ static unsigned char *
binary_escape(unsigned char *from, size_t from_length,
size_t *to_length, PGconn *conn)
{
#if PG_MAJOR_VERSION > 8 || \
(PG_MAJOR_VERSION == 8 && PG_MINOR_VERSION > 1) || \
(PG_MAJOR_VERSION == 8 && PG_MINOR_VERSION == 1 && PG_PATCH_VERSION >= 4)
#if PG_VERSION_HEX >= 0x080104
if (conn)
return PQescapeByteaConn(conn, from, from_length, to_length);
else
Expand Down
4 changes: 1 addition & 3 deletions psycopg/utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ psycopg_escape_string(PyObject *obj, const char *from, Py_ssize_t len,

#ifndef PSYCOPG_OWN_QUOTING
{
#if PG_MAJOR_VERSION > 8 || \
(PG_MAJOR_VERSION == 8 && PG_MINOR_VERSION > 1) || \
(PG_MAJOR_VERSION == 8 && PG_MINOR_VERSION == 1 && PG_PATCH_VERSION >= 4)
#if PG_VERSION_HEX >= 0x080104
int err;
if (conn && conn->pgconn)
ql = PQescapeStringConn(conn->pgconn, to+eq+1, from, len, &err);
Expand Down
9 changes: 4 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,11 @@ def finalize_options(self):
# *at least* PostgreSQL 7.4 is available (this is the only
# 7.x series supported by psycopg 2)
pgversion = self.get_pg_config("version").split()[1]
pgmajor, pgminor, pgpatch = pgversion.split('.')
except:
pgmajor, pgminor, pgpatch = 7, 4, 0
define_macros.append(("PG_MAJOR_VERSION", pgmajor))
define_macros.append(("PG_MINOR_VERSION", pgminor))
define_macros.append(("PG_PATCH_VERSION", pgpatch))
pgversion = "7.4.0"
pgmajor, pgminor, pgpatch = pgversion.split('.')
define_macros.append(("PG_VERSION_HEX", "0x%02X%02X%02X" %
(int(pgmajor), int(pgminor), int(pgpatch))))
except Warning, w:
if self.pg_config == self.DEFAULT_PG_CONFIG:
sys.stderr.write("Warning: %s" % str(w))
Expand Down

0 comments on commit 9067bde

Please sign in to comment.