Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for WSREP SST auth config typo #68

Merged
merged 1 commit into from
May 5, 2021
Merged

Bugfix for WSREP SST auth config typo #68

merged 1 commit into from
May 5, 2021

Conversation

elcomtik
Copy link
Collaborator

@elcomtik elcomtik commented May 5, 2021

Description

When I implemented the WSREP SST auth configuration I made a typo for the default value of wsrep_sst_auth. It is currently set to the variable used to configure MySQL user instead of pair [username]:[password]. The default value for wsrep_sst_auth should be set to:

wsrep_sst_auth="{{ mariadb_sst_username }}:{{ mariadb_sst_password }}"

This issue passed through tests because they do not cover the scenario of using mariabackup SST nor TLS encrypted SST. I do not intend to implement it now, maybe someday when more people will use these features.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants