Skip to content

Bug - Capturing BGP Peers task fails because FRR it's not reloaded and BGPD not started #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gianmarco-mameli
Copy link

Bug - Capturing BGP Peers task fails because FRR it's not reloaded and BGPD not started

Description

Hi, this is the fix for the issue #126, and consists in calling the flush_handlers meta tag after the configuration, to be sure that the FRR and the daemons are reload and started before pass to the monitor tasks
I also fixed some linting

I tried to run the actions but there's some problems: the python called is 3.13, but the Ansible installed on the envs is 7.2.0 that requires Python 3.6 to 3.11, so I managed to run with Python 3.11 but more errors on the Molecule camed up, so I stopped and rollback all, the actions needs a more specific refactor.
The checklist below cannot be all checked up
Thanks

Related Issue

#126

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant