Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRegExp -> QRegularExpression in most places #367

Closed
wants to merge 1 commit into from
Closed

QRegExp -> QRegularExpression in most places #367

wants to merge 1 commit into from

Conversation

Kolcha
Copy link
Contributor

@Kolcha Kolcha commented Aug 7, 2023

QRegExp is deprecated since initial Qt 5 release

the only place that still uses QRegExp is search

@EtlamGit
Copy link
Collaborator

EtlamGit commented Aug 8, 2023

As I understand it, QRegularExpression was recommended instead of QRegExp since Qt5.
But not deprecated. It is deprecated with Qt6 now.

I still struggle a bit with dropping Qt5.9 support completely.
Is there a way to not use QRegularExpression::wildcardToRegularExpression ?

@Kolcha
Copy link
Contributor Author

Kolcha commented Aug 8, 2023

with Qt6 QRegExp is completely removed, not even deprecated. it is included only to Qt5Compat library

Is there a way to not use QRegularExpression::wildcardToRegularExpression ?

good question... I see only the option to implement something "handcrafted", but this is maybe only simple if we need to handle simple cases (aka map "*" in pattern to ".*" in regex, and "?" to ".", which is maybe even irrelevant).
if some "supported wildcard specification" is here, I can look into this. for now I just replicated the same behavior I was able to "touch" and considered reasonable.

another simple option to implement is just to drop any "glob pattern" support and make "inexact" search just a text search

QRegExp is deprecated since initial Qt 5 release

the only place that still uses QRegExp is search
@Kolcha Kolcha changed the title QRegExp -> QRegularExpression QRegExp -> QRegularExpression in most places Aug 9, 2023
@Kolcha
Copy link
Contributor Author

Kolcha commented Aug 9, 2023

dropped changes in search, left just a "safe" changes

@Kolcha Kolcha closed this by deleting the head repository Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants