Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simple object pattern in schema #356

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

danilvalov
Copy link
Contributor

Related issues: #351 #352

@danilvalov danilvalov changed the title Add support for simple pattern Add support for simple object pattern in schema Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.39%. Comparing base (abc3501) to head (6f3e9f2).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
src/parse.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   98.52%   98.39%   -0.13%     
==========================================
  Files           9        9              
  Lines         676      684       +8     
  Branches      264      275      +11     
==========================================
+ Hits          666      673       +7     
- Misses         10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrjono1
Copy link
Owner

mrjono1 commented Aug 17, 2023

Looks good, a few people are going to be happy with this

@Pnlvfx
Copy link

Pnlvfx commented Dec 4, 2024

This is a good on,why isn't it merged?

@mrjono1
Copy link
Owner

mrjono1 commented Dec 4, 2024

It broke existing tests, this pr will now need to be updated from master branch

@danilvalov
Copy link
Contributor Author

@mrjono1 Updated

@danilvalov danilvalov requested a review from mrjono1 December 4, 2024 22:03
@danilvalov
Copy link
Contributor Author

danilvalov commented Dec 4, 2024

@mrjono1 Fixed tests.

But I just copied result tests from workflow results, so I'm not sure everything is ok with withoutDescription option. Please, check it:
https://github.com/mrjono1/joi-to-typescript/pull/356/files#diff-9e9125afe9cea21b9041b826bc4d11b91fdc99c938f818a1956c6b397ac0bfc3

@mrjono1
Copy link
Owner

mrjono1 commented Dec 5, 2024

All looks good to me

@mrjono1 mrjono1 merged commit 70c3b6e into mrjono1:master Dec 5, 2024
4 checks passed
@mrjono1
Copy link
Owner

mrjono1 commented Dec 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants