-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for simple object pattern in schema #356
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 98.52% 98.39% -0.13%
==========================================
Files 9 9
Lines 676 684 +8
Branches 264 275 +11
==========================================
+ Hits 666 673 +7
- Misses 10 11 +1 ☔ View full report in Codecov by Sentry. |
Looks good, a few people are going to be happy with this |
This is a good on,why isn't it merged? |
It broke existing tests, this pr will now need to be updated from master branch |
@mrjono1 Updated |
@mrjono1 Fixed tests. But I just copied result tests from workflow results, so I'm not sure everything is ok with |
All looks good to me |
Related issues: #351 #352