Java solution for removing dups from a string#146
Open
daveDripps wants to merge 3 commits intomre:masterfrom
Open
Java solution for removing dups from a string#146daveDripps wants to merge 3 commits intomre:masterfrom
daveDripps wants to merge 3 commits intomre:masterfrom
Conversation
ottx96
requested changes
Mar 7, 2021
Comment on lines
16
to
26
| if (number > 2) { | ||
| while (number > fibonacciaSequence.size()) { | ||
| int nextNumberInSequence = fibonacciaSequence.get(fibonacciaSequence.size()-1) + fibonacciaSequence.get(fibonacciaSequence.size()-2); | ||
| fibonacciaSequence.add(nextNumberInSequence); | ||
| } | ||
|
|
||
| } else { | ||
| return fibonacciaSequence.get(number-1); | ||
| } | ||
|
|
||
| return fibonacciaSequence.get(number-1); |
Collaborator
There was a problem hiding this comment.
You should simplify your if-statement. You could (should) completely get rid of the "else" case.
fibonacciaSequence.get(number-1);is executed in any case, so removing it makes the code easier to understand overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java solution for removing dups from a string feedback welcome