Repository navigation
NURBSCurve: Fix clone(). - #34542
Merged
Merged
NURBSCurve: Fix clone().#34542
clone().#34542Conversation
Mugen87
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: none
Description
I noticed that
NURBSCurve.clone()returns a curve that can't be used.NURBSCurvegottoJSON()andfromJSON()in #29514 but never acopy(), soclone()falls back toCurve.copy(), which only copiesarcLengthDivisions. The clone ends up withdegreeandknotsundefined and no control points, and the firstgetPoint()call throws:The same thing happens to a
CurvePath(and so aPathorShape) holding aNURBSCurve, sinceCurvePath.copy()clones each of its curves.The new
copy()mirrorsfromJSON(). The knots array is copied and the control points are cloned, so the clone doesn't share state with the source.I added a
clonetest next to the existingtoJSON/fromJSONones. Without the fix it fails on the degree, knots, control points and end knot assertions, then dies ingetPoint(). With it,npm run test-unit-addonspasses (398/398) and eslint is clean on both files.AI tools used