EXRLoader: Add HTJ2K compression support #32233
Draft
+769
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Read payload length | ||
| const payloadLength = dv.getUint32( offset, false ); // big-endian |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 15 hours ago
The fix is simple: remove the unused variable declaration. That is, eliminate the line where payloadLength is declared and assigned:
const payloadLength = dv.getUint32( offset, false ); // big-endianbut preserve the effect of incrementing the offset by 4, as this represents skipping over this header field in the binary data to reach the next field (numChannels). Thus, replace the line with just offset += 4; so the parsing continues correctly. Make this change only in the region of the function where payloadLength is present, i.e., in the surrounding code snippet.
Suggested changeset
1
examples/jsm/loaders/EXRLoader.js
| @@ -1825,8 +1825,7 @@ | ||
| } | ||
|
|
||
| // Read payload length | ||
| const payloadLength = dv.getUint32( offset, false ); // big-endian | ||
| offset += 4; | ||
| offset += 4; // skip payloadLength field (unused) | ||
|
|
||
| // Read number of channels | ||
| const numChannels = dv.getUint16( offset, false ); // big-endian |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31911
Description
Adds support for HTJ2K (High Throughput JPEG 2000) compression in EXRLoader, following OpenEXR 3.4.0 specification. Includes a new JPHLoader for standalone JPEG 2000 files.
Changes
EXRLoader: Added HTJ2K decompression (compression code 11)
JPHLoader: New loader for standalone JPEG 2000/HTJ2K files
Bundled OpenJPH WASM: ~126 KB (105 KB WASM + 21 KB JS)
examples/jsm/libs/openjph/