Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "TSL: add addMethodsChaining (#30201)" #30217

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 27, 2024

Related issue: #30201, #30207 (comment)

Description

Reverting to preferred style.

@sunag sunag marked this pull request as ready for review December 27, 2024 01:57
@sunag sunag added this to the r172 milestone Dec 27, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 488.35
135.72
488.88
135.69
+535 B
-34 B
WebGPU Nodes 487.81
135.6
488.35
135.56
+535 B
-39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.14
151.24
558.8
151.3
+657 B
+61 B
WebGPU Nodes 514.21
140.99
514.87
141.08
+657 B
+92 B

@sunag sunag merged commit 6462c8a into mrdoob:dev Dec 27, 2024
12 checks passed
@sunag sunag deleted the dev-revert-pr branch December 27, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant