New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterialObserver: Clean up #29737

Merged

sunag merged 1 commit into mrdoob:dev from sunag:dev-cleanup-5

Oct 23, 2024

Collaborator

sunag commented Oct 23, 2024

Related issue: #29735

Description

Use RenderContext width and height.


          clean up

30cfbdb

sunag added this to the r170 milestone

sunag marked this pull request as ready for review

October 23, 2024 22:42

github-actions bot commented Oct 23, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	691.57 171.41	691.57 171.41	+0 B +0 B
WebGPU	819.03 220.97	818.87 220.85	-154 B -123 B
WebGPU Nodes	818.54 220.8	818.38 220.72	-154 B -83 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	463.72 112.16	463.72 112.16	+0 B +0 B
WebGPU	539.9 145.85	539.75 145.78	-154 B -66 B
WebGPU Nodes	495.9 135.65	495.74 135.6	-154 B -47 B

sunag merged commit 534a3fc into mrdoob:dev

12 checks passed

sunag deleted the dev-cleanup-5 branch

October 23, 2024 22:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet