GTAONode: Potentially fix getViewPosition().
#29587
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
When working at
SSRNode, I've realized that the current TSL version ofgetViewPosition()is implemented differently. In the original version, the* 2.0 - 1.0is applied to all vector components, not justxandy.Can we please determine which math is correct? If the original is wrong, we should fix the GLSL.
For comparison:
three.js/examples/jsm/shaders/GTAOShader.js
Lines 109 to 113 in 36ae025