Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: add BundleGroup #29277

Merged
merged 2 commits into from
Aug 30, 2024
Merged

WebGPURenderer: add BundleGroup #29277

merged 2 commits into from
Aug 30, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #28719

Add BundleGroup object as proposed #28719 (comment)

Also renamed object -> bundleGroup in Renderer._renderBundle to improve readability.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.4 kB
169.7 kB
685.4 kB
169.7 kB
+0 B
+0 B
WebGPU 818.6 kB
221.3 kB
818.7 kB
221.3 kB
+124 B
+40 B
WebGPU Nodes 818.3 kB
221.2 kB
818.3 kB
221.2 kB
+436 B
+106 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462 kB
111.4 kB
462 kB
111.4 kB
+0 B
+0 B
WebGPU 564.8 kB
153.4 kB
564.8 kB
153.4 kB
+17 B
+6 B
WebGPU Nodes 524.2 kB
143.8 kB
524.2 kB
143.8 kB
-40.64 kB
+10 B

@sunag sunag added this to the r169 milestone Aug 30, 2024
@sunag sunag merged commit 701c101 into mrdoob:dev Aug 30, 2024
12 checks passed
@sunag sunag changed the title WebGPUReneder: add BundleGroup WebGPUReneder: add BundleGroup Aug 30, 2024
@aardgoose aardgoose changed the title WebGPUReneder: add BundleGroup WebGPURenderer: add BundleGroup Aug 31, 2024
sunag added a commit to sunag/three.js that referenced this pull request Aug 31, 2024
@aardgoose aardgoose deleted the bundle-group branch September 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants