Skip to content

Editor: Adds New Project submenu #28325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2024
Merged

Editor: Adds New Project submenu #28325

merged 2 commits into from
May 9, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 9, 2024

This PR added submenu File>New Project>...

All old examples go inside this submenu, e.g. File>New Project>Arkanoid

The old File>New is now File>New Project>Empty

new.project.submenu.mp4

@ycw ycw mentioned this pull request May 9, 2024
Merged
@mrdoob mrdoob added this to the r165 milestone May 9, 2024
@mrdoob
Copy link
Owner

mrdoob commented May 9, 2024

Some DeepScan issues but looks great otherwise!

@ycw
Copy link
Contributor Author

ycw commented May 9, 2024

can ignore https://deepscan.io/dashboard/#view=project&pid=19901&iid=198151526&tid=16600&subview=issues&bid=525701

the binding has consumed here https://github.com/ycw/three.js/blob/0e06563e235d7c168cf32276de41017a75e2241f/editor/js/Menubar.File.js#L60

@mrdoob mrdoob merged commit 774fced into mrdoob:dev May 9, 2024
@ycw ycw deleted the editor-file-example branch January 14, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r165
Development

Successfully merging this pull request may close these issues.
2 participants
@ycw @mrdoob