Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Assign extras to texture. #28226

Merged
merged 2 commits into from
Apr 29, 2024
Merged

GLTFLoader: Assign extras to texture. #28226

merged 2 commits into from
Apr 29, 2024

Conversation

harrycollin
Copy link
Contributor

Modified the GLTFLoader to assign extras to texture user data. I noticed the extras defined in my GLTF textures were not being assigned during loading.

@Mugen87 Mugen87 changed the title Assign extras to texture in GLTFLoader GLTFLoader: Assign extras to texture. Apr 26, 2024
@Mugen87 Mugen87 added this to the r165 milestone Apr 26, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 27, 2024

The failure of E2E tests are unrelated to the changes in GLTFLoader. Not sure what's messing the tests up but a simple rerun did not solve the issue.

This link can be used for testing: https://rawcdn.githack.com/harrycollin/three.js/dev/examples/index.html

@Mugen87 Mugen87 merged commit 15963cd into mrdoob:dev Apr 29, 2024
7 of 11 checks passed
@Mugen87 Mugen87 mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants