Skip to content

WebGLRenderer: Support stenciling transmission buffer contents. #26959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oletus wants to merge 2 commits into from
Closed

WebGLRenderer: Support stenciling transmission buffer contents. #26959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cd434
Support stenciling transmission buffer contents
Oletus Oct 13, 2023
b48bc7b
Fix code style of transmission stencil
Oletus Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,13 +1339,27 @@ class WebGLRenderer {

const isWebGL2 = capabilities.isWebGL2;

const currentRenderTarget = _this.getRenderTarget();

// If the current render target has a stencil buffer, then the transmission render target also needs it so that it's rendered the same way.

const needsStencilBuffer = currentRenderTarget !== null ? currentRenderTarget.stencilBuffer : _this.getContextAttributes().stencil;

if ( _transmissionRenderTarget !== null && needsStencilBuffer === true && _transmissionRenderTarget.stencilBuffer === false ) {

_transmissionRenderTarget.dispose();
_transmissionRenderTarget = null;

}

if ( _transmissionRenderTarget === null ) {

_transmissionRenderTarget = new WebGLRenderTarget( 1, 1, {
generateMipmaps: true,
type: extensions.has( 'EXT_color_buffer_half_float' ) ? HalfFloatType : UnsignedByteType,
minFilter: LinearMipmapLinearFilter,
samples: ( isWebGL2 ) ? 4 : 0
samples: ( isWebGL2 ) ? 4 : 0,
stencilBuffer: needsStencilBuffer
} );

// debug
Expand Down Expand Up @@ -1374,7 +1388,6 @@ class WebGLRenderer {

//

const currentRenderTarget = _this.getRenderTarget();
_this.setRenderTarget( _transmissionRenderTarget );

_this.getClearColor( _currentClearColor );
Expand Down