Removed OimoPhysics example. #25895
Merged
Removed OimoPhysics example. #25895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please also remove Oimo from .eslintrc.json. |
Collaborator
|
The packaging is about the same, but the bottom layer is different, depending on which performance is good and the es file size is compared. https://github.com/saharan/OimoPhysics/blob/master/src/oimo/dynamics/rigidbody/RigidBody.hx https://github.com/dimforge/rapier/blob/master/src/dynamics/rigid_body.rs |
emmanueljl
pushed a commit
to emmanueljl/three.js
that referenced
this pull request
Apr 28, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25892
Description
I've not seen any OimoPhysics adoption in the community and the API wrapper seems to be very similar to Rapier's so I think it'd be better to remove it from the repo and guide new users to the physics libraries with more users.