NodeMaterial.fromMaterial(): Support copying getters and setters #25861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
I already update the screenshot and E2E testing continues failing 🤔 |
Contributor
Author
|
I don't think this PR should break anything or change screenshots... I will test it locally tomorrow. |
Contributor
Author
|
Should be fixed now. (And I think this also fixes a bug in MeshPhysicalNodeMaterial) |
emmanueljl
pushed a commit
to emmanueljl/three.js
that referenced
this pull request
Apr 28, 2023
…oob#25861) * NodeMaterial.fromMaterial(): Support copying getters and setters * Fix * update screenshot * Fix --------- Co-authored-by: sunag <sunagbrasil@gmail.com>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25857 (comment)