-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
WebXR: Added XRButton #25781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXR: Added XRButton #25781
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
cabanier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cabanier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cabanier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these experiences are VR only. Maybe there should be a way to prefer VR instead of AR for such sites.
|
What makes you think they are VR only? The problem is that I've not figured out how to make the background transparent without passing WIP |
Can you not set a background? WebXR are cleared to transparent black. |
|
Ok, figured it out... |
|
So this is a new button that prefers AR mode? If so LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It doesn't look like I have permission to officially sign off
Description
Adds a new XRButton class which creates a
immersive-aror aimmersive-vrsession depending on availability.This allows making projects that run in passthrough headsets and also on vr headsets.
Side note:
I wonder if it was a mistake to call
immersive-arto the session that mobile phones support.Maybe it should have been called
mobile-ar?/cc @toji @cabanier @elalish