WebGPURenderer: Set labels of some WebGPU objects #25773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets labels of some WebGPU objects for helping debug.
Collaborator
|
@takahirox Very good! Coincidentally I thought of suggesting this to you on twitter ^e^ thanks. |
This was referenced Apr 7, 2023
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets labels of some WebGPU objects for helping debug.
WebGPU allows to set label to WebGPU objects.
The label can be used by the browser, OS, or other tools to help identify the underlying internal object to the developer.
For example error message on browser console will be easier to understand to know which WebGPU resource is related. Or WebGPU tools, like my WebGPU devtools, may show more helpful info.
So, I would like to suggest to set label to WebGPU objects to help debugging. In this PR, we set labels only for WebGPU objects that were easy to name.. If my suggestion sounds ok, I hope we can discuss how we can name other objects and make follow up PRs.