Skip to content

Examples: Clean up #25057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Examples: Clean up #25057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69f8079
Update IFCLoader.js
LeviPesin Dec 1, 2022
a8b46c9
Update webgl_nodes_loader_gltf_sheen.html
LeviPesin Dec 1, 2022
0cbf509
Update webxr_ar_plane_detection.html
LeviPesin Dec 1, 2022
0546a4d
Update SVGLoader.js
LeviPesin Dec 1, 2022
cc81fe8
Update NodeBuilder.js
LeviPesin Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/jsm/loaders/IFCLoader.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/jsm/loaders/SVGLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ class SVGLoader extends Loader {

return Math.atan2( sinR, cosR );

}
};

curve.aStartAngle = transformAngle( curve.aStartAngle );
curve.aEndAngle = transformAngle( curve.aEndAngle );
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/nodes/core/NodeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { REVISION, LinearEncoding, Color, Vector2, Vector3, Vector4 } from 'thre
import { mul, maxMipLevel } from '../shadernode/ShaderNodeElements.js';

export const defaultShaderStages = [ 'fragment', 'vertex' ];
export const defaultBuildStages = [ 'construct', 'analyze', 'generate' ]
export const defaultBuildStages = [ 'construct', 'analyze', 'generate' ];
export const shaderStages = [ ...defaultShaderStages, 'compute' ];
export const vector = [ 'x', 'y', 'z', 'w' ];

Expand Down
2 changes: 0 additions & 2 deletions examples/webgl_nodes_loader_gltf_sheen.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@

import * as THREE from 'three';

import { NodeMaterial, color, uv, mix, mul, checker } from 'three/nodes';

import { nodeFrame } from 'three/addons/renderers/webgl/nodes/WebGLNodes.js';

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
Expand Down
2 changes: 0 additions & 2 deletions examples/webxr_ar_plane_detection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import { ARButton } from 'three/addons/webxr/ARButton.js';

let camera, scene, renderer;
let controller;

init();
animate();
Expand Down Expand Up @@ -107,7 +106,6 @@
planesAdded.add( plane );
const frame = renderer.xr.getFrame();
const planePose = frame.getPose( plane.planeSpace, referenceSpace );
const planeGeometry = new THREE.BufferGeometry();
const polygon = plane.polygon;

let minX = Number.MAX_SAFE_INTEGER;
Expand Down