Closed
Conversation
…hree.js-1 into puppeteer-fix-webgpu
Owner
|
Seems like on Linux WebGPU can be enabled by launching Chrome with |
Contributor
Author
|
But it still does not work on Windows... |
munrocket
reviewed
Jun 29, 2022
Contributor
Author
|
Hm, should I split my changes to the lint test (there are not too much of them, actually) to a separate PR? |
Owner
|
Hmm, yeah. It'd be great if you can do a different PR for the lint fixes if possible. |
6 tasks
Contributor
Author
|
I've decided to split this PR into multiple small PRs (both for easier resolving conflicts and making easier to merge), for example:
Will file them soon. (Closing this PR.) |
This was referenced Jan 21, 2023
Merged
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Many changes to the Puppeteer E2E test and tests in general (e.g. lint test).
Removed pageSize code - I think it does not need such fine-tuning, and it actually never worked - the timeout passed to setTimeout was negative in most cases because Math.min was used there instead of Math.max,TODO:
Possibly remove the attempts entirely and instead do one attempt but with large timeouts? This can possibly break if an error unrelated to the timeouts happens,I actually think this is not needed - errors happen rarely, so the second attempt would be rarely needed, so it would not result in slow tests,Investigate whether GitHub Actions allow to autosupply Chromium to the E2E test (so that it would not be required for it to download),(is not needed, GitHub network is very fast)Remove on-the-fly changing ofbuild/three.module.js(this requires regenerating most of the screenshots for some reason, I think?),Current problems:
Fix WebGPU on Linux,(the problem is not in Linux, but in GitHub Actions)fromSurface: falsescreenshoting,window.TESTING,Refactor idleTime and parseTime system (revert to one that was before and add per-example custom timeouts?).(is not needed)output-screenshots/directory from tests on GitHub.Strange errors:
(the following errors happen rarely)