SVGLoader Example: Use srgb output in the svg example #23280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23272
Description
Converts the SVGLoader example page to use sRGB output rather than Linear. I'll note that given that MeshBasicMaterials and therefore no lighting is being used it could be considered more optimal to leave the demo as-is but for the sake of encouraging users to generally use the correct workflow this seems like a good change?
https://raw.githack.com/gkjohnson/three.js/linear-svg-colors/examples/webgl_loader_svg.html
I was taking a look at ColladaLoader and OBJLoader, as well. It doesn't look like there's very explicit documentation on color spaces for these formats and they're more specification by convention. Given that our demos don't adjust the default output color space for the renderer it seems like the assumption is that the textures and colors are sRGB. Is there any evidence or example models that show this isn't always the right thing to do?
cc @donmccurdy @WestLangley @Mugen87