WebGLRenderer: Only use sRGB shader encode for default framebuffer. #23253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Updated builds for further testing: e2dac11 |
Owner
|
Thanks! |
chubei-oppen
added a commit
to chubei-oppen/three.js
that referenced
this pull request
Mar 17, 2022
…uffer. (mrdoob#23253)" This reverts commit 63f7beb.
chubei-oppen
added a commit
to oppenfuture/three.js
that referenced
this pull request
Mar 17, 2022
…uffer. (mrdoob#23253)" (#82) This reverts commit 63f7beb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #23251.
Description
The inline shader sRGB encode only needs to be done for the default framebuffer.