Skip to content

Conversation

@freez10
Copy link

@freez10 freez10 commented Jun 12, 2020

Fixed controls.mouseButtons def example

Fixed controls.mouseButtons def example
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 12, 2020

This change does not look correct, see:

this.mouseButtons = { LEFT: MOUSE.ROTATE, MIDDLE: MOUSE.DOLLY, RIGHT: MOUSE.PAN };

@Mugen87 Mugen87 closed this Jun 14, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2020

I guess the confusion comes from here?

export const MOUSE = { LEFT: 0, MIDDLE: 1, RIGHT: 2, ROTATE: 0, DOLLY: 1, PAN: 2 };

I don't remember adding these constants to MOUSE... 🤔

@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2020

Here's the PR that added these: #16961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants