Skip to content

Conversation

@WestLangley
Copy link
Collaborator

Typically, a single renderer is used to render not only the scene, but for inset viewports, for render-targets, for post-processing, etc. In each case, the rendered scene may or may not have a background. Also, there may be multiple scenes. This can cause the scene background material to be recompiled every frame. (To replicate, add a texture background in /examples/webgl_shadowmap_viewer.html.)

I am thinking webGLBackground may have to be redesigned, but this change in an improvement -- at least in the cases I have studied.

@WestLangley WestLangley added this to the r113 milestone Jan 18, 2020
@WestLangley
Copy link
Collaborator Author

Let's go with this for now. If we encounter additional edge cases, we can revisit this.

@WestLangley WestLangley merged commit 617ea9a into mrdoob:dev Jan 19, 2020
@WestLangley WestLangley deleted the dev_webgl_background branch January 19, 2020 17:14
@mrdoob
Copy link
Owner

mrdoob commented Jan 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants