Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 31, 2019

This PR makes the API more similar to OrbitControls.

@Mugen87 Mugen87 added this to the r111 milestone Oct 31, 2019
@WestLangley
Copy link
Collaborator

WestLangley commented Nov 1, 2019

The only significant difference between OrbitControls and TrackballControls should be the update() method.

Rather than changing the API at this point, I suggest freezing that file, and extending OrbitControls to accommodate TrackballControls -- just as we did with MapControls. That way they will all have the same API.

Edit: It works.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 1, 2019

The API of TrackballControls will change whatever we are going to do. Merging this PR or merge TrackballControls with OrbitControls.

Hence, I see no problem to merge this now since there will be a migration effort (examples, docs etc.) in any case.

@mrdoob mrdoob modified the milestones: r112, r113 Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants