Skip to content

HelioWebXRPolyfill: Fix illegal return statement error. #17838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

HelioWebXRPolyfill: Fix illegal return statement error. #17838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/js/vr/HelioWebXRPolyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
* @author mvilledieu / http://github.com/mvilledieu
*/

if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

if ( 'isSessionSupported' in navigator.xr ) return;
Copy link
Collaborator

@Mugen87 Mugen87 Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please ensure to only use hard tabs in this file? It seems hard and soft tabs are mixed now which ruins proper formatting.

Copy link
Owner

@mrdoob mrdoob Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. Check the files changed section to make sure your pr is clean:
https://github.com/mrdoob/three.js/pull/17838/files

Copy link
Author

@yhuang-ml yhuang-ml Oct 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Converts indentations to tabs and remove trailing spaces.

if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator && 'isSessionSupported' in navigator.xr === false) {

console.log( "Helio WebXR Polyfill (Lumin 0.97.0)" );

Expand All @@ -14,7 +12,7 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

if (
"supportsSession" in navigator.xr === false &&
"supportsSessionMode" in navigator.xr
"supportsSessionMode" in navigator.xr
) {

navigator.xr.supportsSession = function ( /*sessionType*/ ) {
Expand Down