Add tile/offset/lightmap extensions support to GLTF2Loader #11577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @donmccurdy |
|
Hmm, seems like this has conflicts. |
|
Thanks @stevenvergenz – I think you'll need to rebase here to sync up with #11592. I will leave a couple comments on the draft extension PRs. |
|
Is this still needed? |
|
With apologies for the trouble @stevenvergenz, I'd vote that we not merge this PR, but rather work on #11682 to allow GLTF2Loader to use extensions that are written outside of itself. |
|
My related work has been deprioritized for now, so I'm not in a hurry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GLTF2Loader support for the draft extensions AVR_texture_offset_tile and AVR_lights_static. Note that Three.js does not currently allow these extensions to be used together, as texture offset and repeat settings do not affect lightmap or AO textures.