-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Weird DirectionalLight Behavior Between WebGLRenderer and WebGPU Renderer #28642
Comments
Sounds like a bias issue generated from the different depth space of WebGPU and WebGL. Maybe aligning both backend to 0-1 will solve this kind of issue. The best way would be to implement out of the box this extension for WebGL: |
I'm not sure if would be a bias issue when turning on forceWebGL causes the sample to exhibit the same behavior. |
Ah, I see. I misunderstood the issue and thought the behaviors differed between the two backends, not the two renderers. In that case, it might be something to do with |
Getting similar weird moire-like patterns when converting the webgl_postprocessing_pixel example to WebGPU (with and without the WIP PixelationNode pass from PR #28802. Errors appear irrespective of whether the materials are MeshPhongMaterial or MeshPhongNodeMaterial, or whether forceWebGL is set on the THREE.WebGPURenderer. Image below is without any post-processing applied: |
I believe these patterns are fixed with #28926, so I'll close the issue. |
Description
Working from code in pull request #28593, directional lighting behavior is strange when switching from WebGLRenderer to WebGPURenderer.
WebGLRenderer:
WebGPURenderer (behavior the same whether forceWebGL is enabled or not)
WebGPURenderer when switching lighting in webgl_camera_array.html sample from 4 to 50
It seems like the shadow written to the depth buffer in a previous pass is somehow being applied to the mesh's color output.
Reproduction steps
Code
Live example
Screenshots
No response
Version
r166
Device
Desktop
Browser
Chrome
OS
Windows
The text was updated successfully, but these errors were encountered: