GLTFLoader: Unable to load some SkinnedMesh objects in r148

[Samsy]

Description

GLTFLoader did load correctly with this file before the GLTFloader optimisations :
https://github.com/mrdoob/three.js/pulls?q=is:pr+GLTFLoader+is:closed+milestone:r148+in:title

File :
https://res.cloudinary.com/oncyber-io/image/upload/v1666818159/assets/WorkerBot_Posed_10_24_1_eyoaob.glb

Recursive errors on it on threejs editor loader

Reproduction steps

1. Go to threejs editor
2. Drap and drop glb

Code

// code goes here

Live example

• jsfiddle-latest-release
• jsfiddle-dev

Screenshots

No response

Version

last

Device

No response

Browser

No response

OS

No response

[donmccurdy]

It looks like our (refactored) loading process does not correctly handle this case:

1. Node 0 is the root node of the scene, and an ancestor of Node 5
2. Node 5 has a skinned mesh, for which Node 0 is both a joint and the skeleton root
3. loadNode( index ) does not resolve until all node dependencies are resolved, so we hit an infinite loop

/cc @takahirox

[takahirox]

Thanks for reporting the issue and investigation.

Yes, as @donmccurdy explained, loadNode - loadSkin - loadNode can cause "wait for each other". Sorry for the regression. I will look into how to resolve. Perhaps skins need to be processed after building a scene graph (resolving all nodes) as we did before.

[Samsy]

It's not the only case I guess :

Before :

Now :

Note : model is displayed with an envmap here, but shows black in threejs editor

Model link :

https://openseauserdata.com/files/45645ed933109a4a5703bacffdf231ea.glb

[arpu]

It's not the only case I guess :

Before :

Now :

Note : model is displayed with an envmap here, but shows black in threejs editor

Model link :

https://openseauserdata.com/files/45645ed933109a4a5703bacffdf231ea.glb

this looks to a different Problem, this model use deprecated KHR_materials_pbrSpecularGlossiness

[donmccurdy]

@Samsy I've shared some file conversion options to upgrade spec/gloss materials to metal/rough materials in this thread: #24950 (comment)

[takahirox]

Progress...

https://github.com/takahirox/three.js/blob/FixGLTFLoaderNodeParse/examples/jsm/loaders/GLTFLoader.js