-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: run-time configuration #59
Conversation
Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Now almost all options for panel/i2s buffers could be run-time defined, no need to use compile-time defines. This breaks API! Signed-off-by: Emil Muratov <gpm@hotplug.ru>
clear shiftregs after init for FM drivers Signed-off-by: Emil Muratov <gpm@hotplug.ru>
fastmode deprecated, now it is always fast, control bits are updated on brightness change w/o loosing data bits Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Thanks for this. I have created a new branch and made a pull request from your repository. There's a lot of change to merge into the master. My main concern is keeping backwards compatability. |
Got it, thanks. Actually only begin([pins]) is incompatible with custom pin mapping. I could overload it with wrapper to cfg struct to keep an old option compatible. |
By the way, this is really good stuff so thank you again for your contribution. If you could create an overload warpper to the cfg struct for begin() that would be excellent. Any ideas what might cause the artefact at column 128? I'll take a look and see if i see anything on my non-FM panels. |
You are welcome ) Have some other ideas in mind also |
+ construct/overloads for backward compatibility * fixed edge ghosting + added some guard checks Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Pushed a commit with compatibility overloads and a fix for column artefacts. |
Signed-off-by: Emil Muratov <gpm@hotplug.ru>
So, it looks pretty good for me now, no visible artefacts left. Need more testers with other matrixes to confirm/report issues :) |
Farkin fantastic work as always! Good stuff! Going to test it tonight. I like how you've c++ ified the framebuffer structs more instead of being a mix of old c code. |
thanks! yup, took me a while to dig through those nested arrays :) |
Signed-off-by: Emil Muratov <gpm@hotplug.ru>
Hi vortigont, I'm giving you access to the repo directly, please feel free to make changes to the dev branch directly. If you want to propose changes to the master branch can you please raise/propose pull requests from your repo for me to review. Thank you! |
Oh, that's very kind of you, Thanks! |
This is still work-in-progress, but I thought that @mrfaptastic you might wanna look into this and test/add some feedback for other panel types that I do not have.
What is done:
known issues:
P.S. It breaks the API a little bit ) (FIXED)