fix(dap): lldb library paths are strings

[richchurcher]

Description of changes

This:

• switches paths back to strings, lldb is fussy about this apparently

I can't promise this is also true for code-lldb? But it seems likely. Tests are still green.

Fixes #73

Things done

• Tested, as applicable:
  • Manually
  • Added busted specs
• Fits CONTRIBUTING.md

[mrcjkb]

issue: We'll have to make this dependent on whether we're using lldb (adapter.type == 'executable') or codelldb (adapter.type == 'server'), otherwise it'll error with codelldb (see this review comment).

I would suggest to convert the map into a list of strings if (adapter.type == 'executable').

[mrcjkb]

PS, do you have a project I can test this on (ideally with steps to reproduce, for when I implement an integration test)?

[richchurcher]

Yeah, good idea: I'll see what the smallest possible example with dynamic linking is, no sense in throwing all of Bevy at it.

[richchurcher]

(see #64 (review)).

Shoot, sry I missed that one in all the confusion 🙂

[richchurcher]

https://github.com/richchurcher/test-rustaceanvim reproduces the problem. I forgot that there's a dynamic linking feature in Bevy specifically, so did need to include it. Let me know if you want me to leave it there indefinitely or remove it.

[mrcjkb]

https://github.com/richchurcher/test-rustaceanvim reproduces the problem. I forgot that there's a dynamic linking feature in Bevy specifically, so did need to include it. Let me know if you want me to leave it there indefinitely or remove it.

Thanks 🙏

I'll have to pick this up on Friday, but if you're okay with it, we can add it to this repo under a spec/fixtures/dap/dynamic-libs directory.

[richchurcher]

I'll have to pick this up on Friday, but if you're okay with it, we can add it to this repo under a spec/fixtures/dap/dynamic-libs directory.

💯

The latest commit seems to do the trick. Managing a codelldb install is a giant PITA though... is that something the nix flakes can help with? I can confirm it works with lldb-dap.

[mrcjkb]

The latest commit seems to do the trick.

Just tested it with codelldb and lldb (using your test project) and it works for both on my machine.
Thanks for the great work! 🙏

Managing a codelldb install is a giant PITA though... is that something the nix flakes can help with?

The codelldb standalone adapter is currently broken in nixpkgs (it only works when used with the VSCode plugin). I have an open PR that fixes it, but it's a bit hacky.
For now, I've been running:

nix shell "github:mrcjkb/nixpkgs/codelldb-fix#vscode-extensions.vadimcn.vscode-lldb.adapter"

to enter a shell with the adapter from my fork.
There's also an AUR package for Arch (which I haven't tested).