fix(lsp): schedule api calls in on_exit
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Error when stopping the server: "E5560: nvim_del_user_command must not be called in a lua loop callback" `on_exit` runs in `:h lua-loop-callbacks` and thus most `vim.api` functions can't be run in it. Solution: `vim.schedule()` the api calls.
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
approved these changes
Mar 1, 2024
mrcjkb
changed the title
on_exit
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Error when stopping the server:
"E5560: nvim_del_user_command must not be called in a lua loop callback"
on_exitruns in:h lua-loop-callbacksand thus mostvim.apifunctions can't be run in it.Solution:
vim.schedule()the api calls.