fix(lsp): normalize case sensitive root_dir on Windows
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
changed the title
mrcjkb
reviewed
Jan 12, 2024
|
Looks good. Only the stylua check is failing now. |
mrcjkb
reviewed
Jan 14, 2024
mrcjkb
changed the title
root_dir on Windows
mrcjkb
approved these changes
Jan 14, 2024
mrcjkb
previously approved these changes
Jan 14, 2024
|
Tks for merge it. Work as expected. Sorry about not response. |
bltavares
added a commit
to bltavares/rustaceanvim
that referenced
this pull request
Feb 20, 2024
In PR mrcjkb#152, rustacenavim begin storing the `root_dir` with a normalized disk drive format to avoid spawning multiple rust-analyzers while navigating files. This change caused an unintend regression on the neotest integration, as 'find_buffer_by_name' will not match the passed in `path_files`. https://github.com/mrcjkb/rustaceanvim/blob/4987d4159df2f80eb1deda1793ad54082d8ba454/lua/rustaceanvim/rust_analyzer.lua#L61-L63 In summary, neotest would send the following: ``` :Neotest run file -- -> file_path: C:\Users\me\repos\project\src\lib.rs -- -> root_dir: c:\Users\me\projects\src\lib.rs -- -> vim.startswith(file_path, root_dir) -- false No tests found! ``` This commit changes the `rust_analyzer` function to ensure we use the normalized file path when performing the root_dir comparisson, so we can find runnables from Neotest
6 tasks
bltavares
added a commit
to bltavares/rustaceanvim
that referenced
this pull request
Feb 20, 2024
In PR mrcjkb#152, rustacenavim begin storing the `root_dir` with a normalized disk drive format to avoid spawning multiple rust-analyzers while navigating files. This change caused an unintend regression on the neotest integration, as 'find_buffer_by_name' will not match the passed in `path_files`. https://github.com/mrcjkb/rustaceanvim/blob/4987d4159df2f80eb1deda1793ad54082d8ba454/lua/rustaceanvim/rust_analyzer.lua#L61-L63 In summary, neotest would send the following: ``` :Neotest run file -- -> file_path: C:\Users\me\repos\project\src\lib.rs -- -> root_dir: c:\Users\me\projects\src\lib.rs -- -> vim.startswith(file_path, root_dir) -- false No tests found! ``` This commit changes the `rust_analyzer` function to ensure we use the normalized file path when performing the root_dir comparisson, so we can find runnables from Neotest
bltavares
added a commit
to bltavares/rustaceanvim
that referenced
this pull request
Feb 20, 2024
In PR mrcjkb#152, rustacenavim begin storing the `root_dir` with a normalized disk drive format to avoid spawning multiple rust-analyzers while navigating files. This change caused an unintend regression on the neotest integration, as 'vim.startswith' will not match the passed in `path_files`. https://github.com/mrcjkb/rustaceanvim/blob/4987d4159df2f80eb1deda1793ad54082d8ba454/lua/rustaceanvim/rust_analyzer.lua#L77 In summary, neotest would send the following: ``` :Neotest run file -- -> file_path: C:\Users\me\repos\project\src\lib.rs -- -> root_dir: c:\Users\me\projects\src\lib.rs -- -> vim.startswith(file_path, root_dir) -- false No tests found! ``` This commit changes the `rust_analyzer` function to ensure we use the normalized file path when performing the root_dir comparisson, so we can find runnables from Neotest
bltavares
added a commit
to bltavares/rustaceanvim
that referenced
this pull request
Feb 20, 2024
In PR mrcjkb#152, rustacenavim begin storing the `root_dir` with a normalized disk drive format to avoid spawning multiple rust-analyzers while navigating files. This change caused an unintend regression on the neotest integration, as 'vim.startswith' will not match the passed in `path_files`. https://github.com/mrcjkb/rustaceanvim/blob/4987d4159df2f80eb1deda1793ad54082d8ba454/lua/rustaceanvim/rust_analyzer.lua#L77 In summary, neotest would send the following: ``` :Neotest run file -- -> file_path: C:\Users\me\repos\project\src\lib.rs -- -> root_dir: c:\Users\me\projects\src\lib.rs -- -> vim.startswith(file_path, root_dir) -- false No tests found! ``` This commit changes the `rust_analyzer` function to ensure we use the normalized file path when performing the root_dir comparisson, so we can find runnables from Neotest
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.