Merged
Conversation
- OK for BN254_Snarks - Some test failing for BLS12-381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Implementation is fully constant-time.
Speed on BLS12-381: 4761.021 G2mul/s, 210µs/ops, 630k cycles
For reference, status-im/nim-blscurve#47 and status-im/nim-blst#1
The difference with MCL JIT is explained by the very large speed difference for the addition (5.420 vs 4.638) and doubling formula (3095 vs 2.704). Those are slow for several reasons:
__attribute__((naked))pure assembly function to deal with that (and so need a alternative assembler/code generator). The cost seems to be 10%.constantine/constantine/elliptic/ec_weierstrass_projective.nim
Lines 180 to 206 in 92939d4
and nitpicks (don't explain even 0.5% probably):
TODO: