Repository navigation
Accelerate eth_evm_modexp by 25x by dividing input size by 8 - #249
Merged
Merged
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Found by @guidovranken in the Ethereum Foundation sponsored fuzzing campaign,
eth_evm_modexp is very slow on some input.
The issue is located here:
constantine/constantine/ethereum_evm_precompiles.nim
Lines 425 to 428 in d0f4ad8
constantine/constantine/ethereum_evm_precompiles.nim
Lines 455 to 457 in d0f4ad8
The issue is that multiplication scales quadratically, about 1.5n² with the number of words. In our case the ratio before/after is 25x leading to a DOS vulnerability