Update standalone to latest version #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
mr-manuel
reviewed
Mar 31, 2025
| @@ -353,7 +353,7 @@ def check_bms_types(supported_bms_types, type) -> None: | |||
| elif port.startswith(("can", "vecan", "vcan")): | |||
| """ | |||
| Import CAN classes only if it's a CAN port; otherwise, the driver won't start due to missing Python modules. | |||
| This prevents issues when using the driver exclusively with a serial connection. | |||
| This prevents issues when using the driver exclusively with a serial connection | |||
There was a problem hiding this comment.
Please add the dot, so that the file won't change.
There was a problem hiding this comment.
OK, hm, i didn't edit this one I thought
|
Make sure all checks were successful. |
|
The Error of ubms_can.by is still present, but this file is missing in the master, too |
mr-manuel
pushed a commit
that referenced
this pull request
Mar 31, 2025
|
@MacGH23 you mixed tab indentation with spaces. |
|
Hm, where ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Standalone version to latest changes