added initial support for Valence U-BMS on CAN

[gimx]

Hi,

it took longer than anticipated but eventually I am done supporting the Valence U-BMS on can. There are still a number of things TODO where I believe some of them require upstream fixes. A significant difference to the BMS that are supported so far is, that the U-BMS supports multiple strings of modules of 4 cells each, e.g. a 4(x4)s2p config I have at home. That means it can not be assumed that the sum of the cell voltages equals the pack voltage. Each battery module features its own internal balancer. I did not dig deeper, but despite calculating the correct pack voltage, it is either ignored or overwritten upstream. In my case the cell voltage tab shows twice the voltage (becaue of 2 parallel strings), while the main menu overview correctly reports the self.voltage value that has been calculated in the code. I have also attached a candump which you might want to use for testing.
ubms_can_dump.log

Cheers,
Torsten

• 🚨 Make sure the GitHub Actions run fine in your repository. In order to make the GitHub Actions run please select in your repository settings under Actions -> General -> Actions permissions the option Allow all actions and reusable workflows. Check also in your repository settings under Actions -> General -> Workflow permissions if Read and write permissions are selected. After this changes you have to make a new commit, if you don't see any Actions run. This will check your code for Flake8 and Black Lint errors. Here is a short instruction on how to set up Flake8 and Black Lint checks in VS Code. This will save you a lot of time.
• Add your battery class and battery class import in alphabetical order in the etc/dbus-serialbattery/dbus-serialbattery.py
• Add your BMS to the BMS feature comparison page by editing docs/general/features.md
• Add your BMS to the Supported BMS page by editing docs/general/supported-bms.md
• Do not import wildcards *
• If available populate self.max_battery_charge_current and self.max_battery_discharge_current with values read from the BMS
• If available populate self.unique_identifier with a unique value to distinguish the BMS in a multiple battery setup
• If your BMS don't run with the default settings add installation notes to the How to install, update, disable, enable and uninstall docs/general/install.md
• If your BMS needs custom settings that the user should be able to change, add it below the ; --------- BMS specific settings --------- section in the etc/dbus-serialbattery/config.default.ini
• Add the new BMS to the available BMS list under ; --------- Additional settings --------- in the config.default.ini
• Add an entry to the CHANGELOG.md
• Add an entry in the issue template bug_report.yml under id: bms_type
• Add an entry in the issue template support_request.yml under id: bms_type

[mr-manuel]

Looks good at the first sight. Just fix the failed checks.

[mr-manuel]

Also make sure to complete this checklist: https://mr-manuel.github.io/venus-os_dbus-serialbattery_docs/general/supported-bms#add-by-opening-a-pull-request

[gimx]

Hi, thanks for your feedback. I have cvoncluded the open actions.

[mr-manuel]

Two are missing:

• Add your BMS to the BMS feature comparison page by editing docs/general/features.md
• Add your BMS to the Supported BMS page by editing docs/general/supported-bms.md

[gimx]

Two are missing:

* Add your BMS to the [BMS feature comparison](https://mr-manuel.github.io/venus-os_dbus-serialbattery_docs/general/features#bms-feature-comparison) page by editing [docs/general/features.md](https://github.com/mr-manuel/venus-os_dbus-serialbattery_docs/blob/master/docs/general/features.md)

* Add your BMS to the [Supported BMS](https://mr-manuel.github.io/venus-os_dbus-serialbattery_docs/general/supported-bms) page by editing [docs/general/supported-bms.md](https://github.com/mr-manuel/venus-os_dbus-serialbattery_docs/blob/master/docs/general/supported-bms.md)

mr-manuel/venus-os_dbus-serialbattery_docs#5